daostack / daostack/arc.js

datetimes should be consistent in type

Open
#518 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Many dates are supplied as `Date` and many are supplied as `Number`. This kind of inconsistency can cause all kinds of issues with consuming software (immediate example: https://github.com/daostack/alchemy/issues/1984)

1. They should all be supplied as either `Date` or `number` (`Date` seems more friendly to me, but `number` is more agnostic.
1. They should all be declared consistently in their governing interfaces.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.