daostack / daostack/arc.js

make graphql be an external dependency in rollup

Open
#439 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Underscore protocol only allows a single instance of graphql to be present. I believe that simply enforces a restriction of graphql itself. To provide the most options for dApps using multiple packages that each leverage graphql, the client lib can define graphql as an external dependency in the rollup configuration. Then if the dApp chooses to define graphql as a top-level dependency, it may, and as long as it means the client lib's own top-level dependency, the client lib will defer to that. Otherwise, client lib will us the version that it has defined as its own top-level dependency (just as it does now).

Thus I suggest that the client lib define graphql as an external dependency in its rollup configuration.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Rollup configuration used by the TypeScript client library and inspect how graphql is bundled and declared as a dependency. Done means graphql is treated as external there while the client library retains its declared top-level fallback behavior; verify the package build.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, rollup, typescript
Domain
build-system, frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.