daostack / daostack/alchemy

unsubscribe should be called on ethBalance subscriptions

Open
#1,916 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
TypeScript
Stars
146
Forks
78
PR merge metrics
No merged PRs in 30d

Description

`unsubscribe` is not being called on `ethBalance` subscription observables. I'm guessing that this might be a flaw in `withSubscription` which was designed to guarantee that `unsubscribe` would always be called on its observables. Or it may be a flaw in how we are using `combineLatest`. Either way or any other way, it is a memory/resource leak. @jellegerbrandy

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.