danielroe / danielroe/trellis-valet-driver

Add Valet 4 version

Open
#3 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
PHP
Stars
28
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Valet 4 requires some [changes to the Drivers synthax](https://laravel-news.com/valet-v4-is-released#content-custom-drivers).

1. Adding namespace
```
namespace Valet\Drivers\Custom;
use Valet\Drivers\ValetDriver;
```
1. Add attribute typing
```
public function serves(string $sitePath, string $siteName, string $uri): bool
...
public function isStaticFile(string $sitePath, string $siteName, string $uri)/*: string|false */
...
public function frontControllerPath(string $sitePath, string $siteName, string $uri): string
```

Contributor guide

Open the contributing guide

Research direction

Start by locating the custom Valet driver implementation and compare its methods with the Valet 4 custom-driver syntax in the linked Laravel News article. The work is done when the driver uses the requested namespace and compatible method attribute types.

Written by the indexing model from the issue text.

Assessment

Tech stack
laravel, php
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.