danielmiessler / danielmiessler/LifeOS
7.40.4: substituteTree corrupts its own checker (IDENTITY_PLACEHOLDERS) + template bodies
- Dominant language
- TypeScript
- Stars
- 19k
- Forks
- 2.5k
- Avg merge
- 8d 17h
- Merged PRs (30d)
- 1
Description
Setup step 9d runs substituteTree(configRoot) over the whole tree. Two problems in 7.40.4: (1) skills/LifeOS/Tools/InstallEngine.ts line ~476 declares IDENTITY_PLACEHOLDERS with {{DA_NAME}}/{{PRINCIPAL_NAME}}/{{LIFEOS_VERSION}} tokens, so substitution rewrites the checker's own list to bare values (e.g. CJ/Alberto) and checkSurvivingPlaceholders then false-positives on every file mentioning the user's name. (2) Art thumbnail-templating and Fabric pattern bodies carry {{DA_NAME}}/{{PRINCIPAL_FULL_NAME}} as example text and get wrongly substituted. Suggest: exclude Tools/ + example bodies from substitution scope, or match whole-file template markers. Found during a Windows install; fixed locally by restoring 9 files from payload.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with setup step 9d and skills/LifeOS/Tools/InstallEngine.ts around line 476, then inspect the nine files restored during the Windows install. Reproduce the substitution and trace how checker tokens and template bodies are handled. Done means the checker retains its literal placeholders, example bodies remain unchanged, and valid files no longer trigger false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100