danielmiessler / danielmiessler/LifeOS

The public-push check can miss the branch you're pushing

Open Beginner friendly
#2,099 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
19k
Forks
2.5k
Avg merge
8d 17h
Merged PRs (30d)
1

Description

On a big project, the check only looks at the branch you have open, not the one you're sending. So a secret on another branch could slip through.

I found it from the other side: it blocked my push because of an old branch I had open, even though what I was sending was clean.

The check is in LifeOS/install/hooks/PublicPushGate.hook.ts, around line 119. It should look at the branch being pushed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in LifeOS/install/hooks/PublicPushGate.hook.ts around line 119 and trace which branch the public-push check inspects. Update the check so it evaluates the branch being sent, then verify that a clean push is not blocked by another open branch and that secrets on the pushed branch are detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, typescript
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.