danielmiessler / danielmiessler/Fabric
[Bug]: interactive setup does not accept carriage return
- Dominant language
- Go
- Stars
- 43.9k
- Forks
- 4.3k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 8
Description
### What happened?
After downloading the latest binary for the first time via `curl` and then running `fabric --setup`, carriage return is not accepted via STDIN (in order to accept the listed default repository url per the interactive prompt). This is the case both without a space and including a space.
This was the same for the `brew` install (tested after removing the curl binary), and it presented the same issue. I also trying to put a value in (see screenshots) which also failed to accept carriage return.
### Steps to reproduce:
- `curl -fsSL https://raw.githubusercontent.com/danielmiessler/fabric/main/scripts/installer/install.sh | bash`
- `fabric --setup`
- press enter to accept default repo listed
- carriage return not accepted from STDIN
### Setup
- Terminal: kitty 0.41.0
### Operating System
macOS - Silicon (arm64)
### OS Version
```shell
macOS: Sequoia 15.1
```
### How did you install Fabric?
Release Binary - macOS (arm64)
### Version
```text
1.4.455
```
### Relevant log output
```shell
❯ fabric --setup
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
🎉 Welcome to Fabric! Let's get you set up.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📥 Step 1: Downloading patterns (required for Fabric to work)...
[Patterns Loader]
Enter the default Git repository URL for the patterns (leave empty for 'https://github.com/danielmiessler/fabric.git' or type 'reset' to remove the value):^M^M^M^C
❯ fabric --setup
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
🎉 Welcome to Fabric! Let's get you set up.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📥 Step 1: Downloading patterns (required for Fabric to work)...
[Patterns Loader]
Enter the default Git repository URL for the patterns (leave empty for 'https://github.com/danielmiessler/fabric.git' or type 'reset' to remove the value): ^M ^M^M^M^C
```
### Relevant screenshots (optional)
Contributor guide
Research direction
Start by running the reported release-binary setup flow with `fabric --setup` on macOS, using the Step 1 patterns prompt and reproducing the carriage-return input shown in the log. Trace the interactive setup and patterns-loader entry points, then verify that pressing Return accepts the default repository URL or a supplied value without interruption.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100