danieljvickers / danieljvickers/SedPlot
Reduce FFMPEG Size
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
Currently, we attach ffmpeg by literally binding the entire ffmpeg zip drive with the binary. This is nice because it garuntees that we won't miss anything, but ends up making the code very large (200 MB) and slows it down because so many files were installed. There are a few steps to achieving this:
1. We should replace the `--add-data` in the `.github/workflows/build.yaml` with an `--add-binary`.
2. We need to change the builder so that we search for the OS-dependent executable path
3. We need to refactor how we search for the ffmpeg EXE in the python scripts
After that, we need to test and ensure that it still works
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.