danielgtaylor / danielgtaylor/python-betterproto
from_dict() does not cast floating point types
Open
bug
good first issue
low priority
small
- Dominant language
- Python
- Stars
- 1.8k
- Forks
- 234
- PR merge metrics
- No merged PRs in 30d
Description
When you pass in the dictionary a float to an int field, this is casted to int (line 890 `betterproto/__init__.py`). I would expect a similar behaviour in the reverse situation when you pass an int to a float field. Right now you end up with an object having an int in a field which should contain a float.
Contributor guide
Assessment
This issue has not been assessed yet.