danielgtaylor / danielgtaylor/python-betterproto

Allow mapping google.protobuf.duration to Optional datetime.timedelta

Open
#246 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.8k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

We had some issues loosing a zero-duration. Currently, if a serialized Protobuf message contains a 0-duration like `myDuration` in this example:
```protobuf
syntax = "proto3";

message Some {
string someField = 1;
google.protobuf.duration myDuration = 2;
}
```
and data like
```json
{
"someField": "42",
"myDuration": "0s"
}
```
this `myDuration` field gets correctly deserialized into a `timedelta(0)`. However, when forwarding/serializing that Python object again, the duration gets lost:
```json
{
"someField": "42",
// myDuration missing
}
```
Because `timedelta(0)` is the default value, it appearently represents no-value in betterProto (see [Well known Google Types](https://github.com/danielgtaylor/python-betterproto#well-known-google-types)).

Is it possible to configure the mapping from Protobuf's `duration` to an Optional timedelta value so that no-value can be distinguished from a 0-value in Python?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.