danielgtaylor / danielgtaylor/python-betterproto

Cannot set timeout in generated `ServiceStubs`

Open
#245 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.8k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

It is not possible to set `timeout`s in generated `ServiceStubs`.

I believe betterproto supports timeouts since #32 but it seems like the code generation does not implement timeouts.

[Here](https://github.com/qria/python-betterproto/tree/feature/add-timeout) is my fork that I am currently using to use timeouts.

I didn't submit a PR because it seems like there's much context, such as 'does timeout only apply in case of `not method.client_streaming and method.py_input_message and method.py_input_message.fields`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.