danielgtaylor / danielgtaylor/python-betterproto

nested empty types not in to_dict

Open
#199 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.8k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

I am not sure if I am wrong here but when executing this:

```python
from dataclasses import dataclass

import betterproto

@dataclass
class Inner(betterproto.Message):
inner1: str = betterproto.string_field(1)
inner2: str = betterproto.string_field(2)

@dataclass
class Test(betterproto.Message):
name: str = betterproto.string_field(1)
inner: "Inner" = betterproto.message_field(2)

test = Test(name='123', inner=Inner())
print(test.to_json())
```

I receive the output `{"name": "123"}`. I would expect the output to be`{"name": "123", inner:{}}`.
Of course there is a similar issue with the `to_dict` function

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.