danielgtaylor / danielgtaylor/malt.io

Some xml characters not escaped on beerxml export

Open
#92 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
26
Forks
11
PR merge metrics
No merged PRs in 30d

Description

I exported a few recipes, and noticed that some xml characters weren't escaped.

For example, the ' was not escaped to ' in the NAME element of http://www.malt.io/users/david/recipes/la-premire-midwest-supplies-autumn-amber-ale-/beerxml

I thought I saw an & in another NAME element escaped to & however I looked again and it was properly escaped.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the BeerXML export from the recipe URL in the issue and inspect the export entry point for how the NAME element is serialized. Verify that an apostrophe is escaped in NAME and that existing ampersand escaping remains correct, then confirm the generated BeerXML output.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.