danielgtaylor / danielgtaylor/aglio

Server option does not fully lock the port.

Open
#292 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
CoffeeScript
Stars
4.7k
Forks
471
PR merge metrics
No merged PRs in 30d

Description

`--server` option starts the server on port `3000` but still this port is accessible by other apps.
- I can start `aglio` even when the port is already taken by another process. (Tried with `node`). In this case, request will be served by the node app.
- I can start another process (Tried with `node`) even when `aglio` is running on the same port. In this case, request will be served by the `aglio` app.
- `node` is not allowing to start another `node` process if port is already taken.

What could be the issue. Ideally the second process should have failed with `Port is already taken`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the `--server` option handling and the code that binds port `3000`. Reproduce the issue with `aglio` and another Node process using the same port, then trace why both processes start. Done means a second process fails with a clear `Port is already taken` error instead of serving requests through either app.

Written by the indexing model from the issue text.

Assessment

Tech stack
coffeescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.