danielgerlag / danielgerlag/workflow-core

WorkflowPuger does not purge terminated Workflow

Open
#995 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
5.9k
Forks
1.3k
Avg merge
1d 1h
Merged PRs (30d)
5

Description

**Describe the bug**
I am using WorkflowPurger to cleanup old workflow persisted entries. Works fine as long as the have a CompletedTime. This seems to be not the case for WF with Status Terminated (3). I am using EF 5 and the default provider for it.

**To Reproduce**
Steps to reproduce the behavior:
Terminate Workflow with Exception and have .OnError(Terminate) in the Workflow definition.

**Expected behavior**
I should be possible to purge a terminated Workflow with CompletedTime == null

**Additional context**
Simple Suggestion: Allow a nullable datetime in Method PurgeWorkflows.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.