danielgerlag / danielgerlag/workflow-core

RabbitMQ.Client v6 support

Open
#992 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
5.9k
Forks
1.3k
Avg merge
1d 1h
Merged PRs (30d)
5

Description

**Is your feature request related to a problem? Please describe.**
`WorkflowCore.QueueProvider.RabbitMQ` uses RabbitMQ.Client v4.1.3 as a dependency. Starting from RabbitMQ.Client v6.0.0 the `Body` property in the `BasicGetResult` class is of type `ReadOnlyMemory` (instead of `byte[]`). That breaks `WorkflowCore.QueueProvider.RabbitMQ`. Is there a chance to upgrade the dependency? (the current one is from 2017y)

**Describe the solution you'd like**
Upgrade RabbitMQ.Client dependency to the newest version

**Additional context**
The line that causes the problem:
https://github.com/danielgerlag/workflow-core/blob/273b9b42de4417e8c00f474512b0b18bf1fd355e/src/providers/WorkflowCore.QueueProviders.RabbitMQ/Services/RabbitMQProvider.cs#L66

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.