danielgerlag / danielgerlag/workflow-core

[Question]:Security Risk in TypeNameHandling.All in JsonSerializerSettings

Open
#1,280 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
5.9k
Forks
1.3k
Avg merge
1d 1h
Merged PRs (30d)
5

Description

Issue Description:

I have identified a potential security vulnerability in the code where external data sources are being deserialized using Newtonsoft.Json with TypeNameHandling.All enabled. This setting allows the deserialization of types based on the type information present in the JSON payload. While convenient for polymorphic deserialization, it can also pose a security risk if the JSON data comes from untrusted sources. This setting could potentially be exploited for remote code execution (RCE) attacks if not handled carefully.

Code Reference:https://github.com/danielgerlag/workflow-core/blob/a761d783fe6f6bf9b0c6797321a439bf6f94c827/src/providers/WorkflowCore.Providers.Azure/Models/PersistedWorkflow.cs#L31

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading src/providers/WorkflowCore.Providers.Azure/Models/PersistedWorkflow.cs at line 31 and trace how the persisted data reaches deserialization. Confirm whether the input can be untrusted and document the security impact and required remediation; done means the risk and next action are clearly established.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.