danielgerlag / danielgerlag/workflow-core

WorkflowExecutor is not sending LifeCycleEvents.WorkflowCompleted when Workflow is marked with IStepBuilder.EndWorkflow

Open
#1,097 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
5.9k
Forks
1.3k
Avg merge
1d 1h
Merged PRs (30d)
5

Description

WorkflowExecutor is not sending LifeCycleEvents.WorkflowCompleted when Workflow is marked with IStepBuilder.EndWorkflow

just check https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Services/WorkflowExecutor.cs

https://github.com/danielgerlag/workflow-core/blob/master/src/WorkflowCore/Primitives/EndStep.cs

returns

ExecutionPipelineDirective .EndWorkflow

=> WorkflowExecutor .InitializeStep returns fals and the Event is not fired.

Additional, I think the status of the worklfow is set to early to complete in line 259.

You may request the value from execitionContext when middlewareRunner is executed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.