danhper / danhper/atomic-chrome

Doesn't work with Brave: WebSocket connection to localhost fails

Open
#36 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
907
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Every time I try to edit with this extension in Brave, it fails with the error `WebSocket connection to 'ws://localhost:64292/' failed`:

![image](https://user-images.githubusercontent.com/100738/113507525-ff632580-9542-11eb-85a1-d586201cd413.png)

This was on Brave version 1.21.73 Chromium: 89.0.4389.72 (Official Build) (64-bit). I have also just tested on Google Chrome version 89.0.4389.72 (Official Build) (64-bit) and it works perfectly. [The same goes for the "Edit with Emacs" extension](https://github.com/stsquad/emacs_chrome/issues/179) which also uses websockets on `localhost`. So this appears to be an issue with Brave :-(

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the localhost WebSocket failure in Brave 1.21.73 and compare it with Chrome 89.0.4389.72, using the reported ws://localhost:64292/ connection as the starting point. Trace where the extension opens that connection; done means editing with the extension works in Brave without the WebSocket error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.