danger / danger/swift

Dangerfile evaluation is single threaded

Open
#99 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

Right now it looks like evaluation of a DangerFile is basically single threaded, meaning if you want to do anything with the network you have to have dispatch locks. This is likely because we're not executing the app, but running the swift compiler int an faux-eval mode.

This might not work in the long run, and we might need to switch out to actually compiling using swift-pm and then executing that binary which handles the eval runtime.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.