danger / danger/swift

Incorrect exit status for fails

Open
#645 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

Hi,

I run danger-swift on Bitrise as a script step in which I execute:
`swift run danger-swift ci`

and regardless of the output it always return 0 as status code.

Danger correctly finds violated rules, shows a message "Failing the build, there are x fails." and posts messages under the PR/MR but the exit status is always 0 so the CI build continues instead of failing. I've also tried to run it with the "--fail-on-errors" flag but it didn't helped.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.