danger / danger/swift

`swift run danger-swift edit` doesn't include plugins; `swift run danger-swift (ci|local)` works

Open
#590 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

I have a `danger` subdirectory in my project.

This is it's structure:
```
.
├── DangerDependencies
│   └── Fake.swift
├── Dangerfile.swift
├── Package.resolved
└── Package.swift
```

This is **Dangerfile.swift**:

```swift
import Foundation
import Danger
import DangerSwiftKantoku

let danger = Danger()
let kantokuConfig = XCResultParsingConfiguration(
codeCoverageRequirement: .none,
reportingFileType: .modifiedAndCreatedFiles
)
danger.kantoku.parseXCResultFile(at: "somePath", configuration: kantokuConfig)
```

and this is **Package.swift**:
```swift
// swift-tools-version:5.8
import PackageDescription

let package = Package(
name: "DangerDepsProject",
platforms: [.macOS(.v12)],
products: [
.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"])
],
dependencies: [
.package(url: "https://github.com/danger/swift.git", from: "3.17.1"),
.package(url: "https://www.github.com/yumemi-inc/danger-swift-kantoku.git", from: "0.1.1")
],
targets: [
.target(
name: "DangerDependencies",
dependencies: [
.product(name: "Danger", package: "swift"),
.product(name: "DangerSwiftKantoku", package: "danger-swift-kantoku")
],
path: "DangerDependencies"
)
]
)

```

This works and it successfully uses plugins:
```bash
cd danger
swift build
swift run danger-swift local --failOnErrors --cwd ../ --base origin/develop
```

But I want to be able to edit the project, so I call this:
```bash
cd danger
swift build
swift run danger-swift edit
```

And this does not work, it generates the project where Package.swift does not contain plugins, so it won't build:

Generated Package.swift:
```swift
// swift-tools-version:5.8
// danger-dependency-generator-version:3

import PackageDescription

let package = Package(
name: "Dangerfile",
platforms: [.macOS(.v13)],
products: [.executable(name: "DangerDependencies", targets: ["Dangerfile"])],
dependencies: [
.package(url: "https://github.com/danger/swift.git", exact: "3.17.1")
],
targets: [.executableTarget(name: "Dangerfile", dependencies: [
.product(name: "Danger", package: "swift")
])],
swiftLanguageVersions: [.version("5")]
)
```

Swift Danger Version: **3.17.1**

Example project: [danger.zip](https://github.com/danger/swift/files/12342588/danger.zip)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.