danger / danger/swift

Danger-Swift as SPM Plugin? [IDEA]

Open
#586 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

At WWDC22, Apple introduced the concept of [plugins](https://github.com/apple/swift-package-manager/blob/main/Documentation/Plugins.md) for SPM. These plugins allow us to specify scripts that run either at build time or can be invoked manually.

Today, Danger Swift's setup requires "working around the system" to use the docs own words. I wonder whether the plugin system in SPM would remove the need to create a special target to get libDanger compiled. Once implemented as a plugin, it seems all one has to do is import it as a dependency like any other Swift Package, and then simply run something like:

`swift package danger pr https://github.com/Moya/Harvey/pull/23`

I don't see mass adoption of SPM plugins quite yet -- there may be reason for that. Perhaps at WWDC23 in a few days we'll see some further refinements to plugins.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.