danger / danger/swift

SwiftLint ignores "swiftlint:disable" comments on Linux with Swift 5.7 environment

Open
#556 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

# Issue

SwiftLint doesn't ignore rules even though there is `swiftlint:disable` comments in our code.
This issue is only happened on Linux with greater than or equal to Swift 5.7 environment.

image

# Root cause

it seems SwiftLint itself had a problem and they've already fixed in 0.50.0 release.
However danger-swift is using SwiftLint 0.48.0 now.

# Comment

Though bump SwiftLint might fix this issue, according to their release note, SwiftLint requires Swift 5.7 after that.
@f-meloni

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.