danger / danger/swift

Bitrise ENV set https URL faling

Open
#396 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
1.1k
Forks
152
Avg merge
9h 54m
Merged PRs (30d)
2

Description

We are using GITLAB + BITRISE for iOS CI/CD pipeline

As part of CI/CD step, I set env_var
| |
**+ https_url=https://[REDACTED]:[REDACTED]@gitlab.org.io/ios/project.git
+ envman add --key GIT_REPOSITORY_URL --value https://[REDACTED]:[REDACTED]@gitlab.org.io/ios/project.git
+ '[' '!' -z 1234 ']'
+ envman add --key BITRISEIO_PULL_REQUEST_REPOSITORY_URL --value https://[REDACTED]:[REDACTED]@gitlab.org.io/ios/project.git**

After this step, I do run danger-swift ci steps at this step danger not able to authorize gitlab URL and it gives 401 unauthorized error. I think it may be due to GITHUB_REPOSITORY_URL need to be decoded before sending to KY process.

Error: HTTPError: Unauthorized
at fn (/snapshot/danger-js/node_modules/ky/umd.js:251:12)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Ky._retry (/snapshot/danger-js/node_modules/ky/umd.js:319:12) {
name: 'HTTPError',
response: Response {
size: 0,
timeout: 0,
[Symbol(Body internals)]: { body: [PassThrough], disturbed: true, error: null },
[Symbol(Response internals)]: {
url: 'https://gitlab.com/api/v4/projects/https%3A%2F%2F[REDACTED]%3A[REDACTED]%40gitlab.project_domain.com%2Fios%2Fproject_name/merge_requests/1234/changes',
status: 401,
statusText: 'Unauthorized',
headers: [Headers]
}
},
description: '401 Unauthorized'
}

May be decode url as it may possible git env variables return encoded URL.

![Screen Shot 2020-12-02 at 12 39 54 AM](https://user-images.githubusercontent.com/73841762/100833000-fd734380-3436-11eb-8415-8758c44a2c57.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.