danger / danger/peril

After upgrading Peril, unable to send markdown to new issues

Open
#328 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
460
Forks
55
PR merge metrics
No merged PRs in 30d

Description

Good evening! I upgraded to the latest Peril (from whatever was on master January 5th, Heroku won't give me the initial deploy sha) and it's no longer posting comments to GitHub. Everything looks fine in the logs and it does _say_ it's commenting, but it never shows up. Here're the logs from a request:

```
2018-06-25T02:56:03.718307+00:00 app[web.1]: info: ☢️ Starting up Peril
2018-06-25T02:56:03.720671+00:00 app[web.1]: info: ✓ Papertrail
2018-06-25T02:56:03.721200+00:00 app[web.1]: info: ✓ Clustering
2018-06-25T02:56:03.721468+00:00 app[web.1]: info: ✓ JSON Db at ashfurrow/peril-settings@settings-peril.json
2018-06-25T02:56:03.721719+00:00 app[web.1]: info: ✓ Server:
2018-06-25T02:56:03.722045+00:00 app[web.1]: info: - Local: http://localhost:28386
2018-06-25T02:56:03.846930+00:00 heroku[web.1]: State changed from starting to up
2018-06-25T03:04:25.896267+00:00 app[web.1]: info:
2018-06-25T03:04:25.896436+00:00 app[web.1]: info: ## issues.opened on unknown
2018-06-25T03:04:25.896692+00:00 app[web.1]: info: 1 run needed: rules/all-issues.ts
2018-06-25T03:04:27.007179+00:00 heroku[router]: at=info method=POST path="/webhook" host=ashfurrow-peril.herokuapp.com request_id=5a8ba48c-7b4b-41a0-b113-4d835c053016 fwd="192.30.252.38" dyno=web.1 connect=1ms service=1146ms status=200 bytes=1078 protocol=https
2018-06-25T03:04:26.976513+00:00 app[web.1]: info: [runner] - Commenting, with results:
2018-06-25T03:04:26.976527+00:00 app[web.1]: mds: 2
2018-06-25T03:04:26.976528+00:00 app[web.1]: messages: 0
2018-06-25T03:04:26.976530+00:00 app[web.1]: warns: 0
2018-06-25T03:04:26.976531+00:00 app[web.1]: fails: 0
2018-06-25T03:04:26.976533+00:00 app[web.1]:
```

Hmm! I took a look through the recent issues on Peril and Danger.js, as well as the changelogs, but didn't see anything that could explain it. I'm going to try looking into it more tomorrow, let me know if this rings a bell. My settings repo is at https://github.com/ashfurrow/peril-settings and here's the rule that was executed in the logs above: https://github.com/ashfurrow/peril-settings/blob/master/rules/all-issues.ts. Thanks!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.