danger / danger/danger

Message from Danger shown improperly on GitHub

Open
#753 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
5.7k
Forks
488
PR merge metrics
No merged PRs in 30d

Description

Here is example of the message that `danger local` output to the console:

- [ ] maven-surefire-plugin error in src/test/groovy/ru/mystamps/web/service/UserServiceImplTest.groovy:

Test case `registerUser() should fill role field` fails with message:
```
org.spockframework.runtime.SpockComparisonFailure:
Condition not satisfied:

user?.role == UserDetails.Role.USER
| | |
| null false
AddUserDbDto(login=test, role=null, name=Test Name, email=test@example.org)

at ru.mystamps.web.service.UserServiceImplTest.registerUser() should fill role field_closure5(UserServiceImplTest.groovy:162)
at ru.mystamps.web.service.UserServiceImplTest.registerUser() should fill role field(UserServiceImplTest.groovy:159)

```

And this is how it's rendered by GitHub (note on the trailing symbol at the end of the comment):
![danger-bug](https://cloud.githubusercontent.com/assets/87088/23578894/44c81928-00e1-11e7-9383-abfee75ceebc.png)

Here is an HTML version of this comment:
```html

🚫
maven-surefire-plugin error in src/test/groovy/ru/mystamps/web/service/UserServiceImplTest.groovy:

Test case registerUser() should fill role field fails with message:


org.spockframework.runtime.SpockComparisonFailure: 

Condition not satisfied:

user?.role == UserDetails.Role.USER

| | |

| null false

AddUserDbDto(login=test, role=null, name=Test Name, email=test@example.org)


at ru.mystamps.web.service.UserServiceImplTest.registerUser() should fill role field_closure5(UserServiceImplTest.groovy:162)

at ru.mystamps.web.service.UserServiceImplTest.registerUser() should fill role field(UserServiceImplTest.groovy:159)

</

```

Could you help me to find out who is adding this trailing part?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.