danger / danger/danger

Incorrect MR ID for GitLab with Drone

Open
#499 44 comments 0 reactions 0 assignees View on GitHub
Bug GitLab
Dominant language
Ruby
Stars
5.7k
Forks
488
PR merge metrics
No merged PRs in 30d

Description

# Report
## What did you do?

I ran Danger on Drone using a private GitLab instance.
## What did you expect to happen?

I expected Danger to run correctly.
## What happened instead?

Danger ran, but failed because the ID used to fetched the merge request details was the `iid`(the project specific merge request id) not the global merge request id that the API expects.
## Your Environment
- Which CI are you running on? Drone
- Are you running the latest version of Danger? Yes

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.