danger process isn't exiting the process with the same error code as the subprocess
Open
bug
help wanted
You Can Do This
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 381
- Avg merge
- 2h 8m
- Merged PRs (30d)
- 6
Description
I saw it "fail" a bunch, but actually pass. It even said "process exited with code '1'" or whatever.
Contributor guide
Research direction
Start by tracing how the Danger process handles the subprocess exit status and reproduce the reported case where code 1 is printed but the overall command passes. Done means the parent process exits with the same error code as the subprocess and the mismatch is covered by an appropriate test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- ci-cd, cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100