danger / danger/danger-js

Feature - Danger Id on the GH Action

Open
#1,464 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5.5k
Forks
379
Avg merge
2h 8m
Merged PRs (30d)
6

Description

I am using danger to create an reusable workflow to do some common validations across multiple repositories. It works great. The problem is that some repositories already has the dangerfile configured and both the workflows (the reusable workflow and the specific workflow from the repository) are overriding the same comment. Would be nice to have the ability to pass the --id for the github action.

```yaml
- name: Run Danger
uses: danger/danger-js@12.3.1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
id: my-custom-id
```

Contributor guide

Open the contributing guide

Research direction

Start at the GitHub Action entry point referenced as danger/danger-js@12.3.1 and trace how the YAML `with.id` input reaches the Danger invocation. Compare this with the requested `--id` behavior; done means reusable and repository workflows can use distinct comment IDs without overriding each other, with coverage for the action input.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.