danger / danger/danger-js

[Feature Request] Configurable Emoji / PR Comment templates

Open
#1,111 6 comments 3 reactions 0 assignees View on GitHub
enhancement Open for Discussion
Dominant language
TypeScript
Stars
5.5k
Forks
381
Avg merge
2h 8m
Merged PRs (30d)
6

Description

It's been years that I've been a fan and contributor to DangerJS, but one thing that always gives me a heart attack is the emoji in the DangerJS signature line -- because it sometimes renders in a clipped way in email Previews:
![Screenshot of the email preview showing DangerJS's emoji '🚫'](https://user-images.githubusercontent.com/209712/108283322-ee4b8a00-7137-11eb-9064-4631f1b139e8.png)
*note: that this sometimes gets shortened even more awkwardly*

Is there any way to customize this emoji?

A. Would we object to a global change of it to something more neutral or less negatively interpreted?
B. Would we object to a feature allowing people to override what it will be?

I haven't explored the code to see how hard this would be yet, as I first wanted input before submitting a PR.

Thanks for your thoughts!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.