danger / danger/danger-js

[BUG] Bamboo CI 7.0 compatibility and regexp extension

Open
#1,052 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
5.5k
Forks
381
Avg merge
2h 8m
Merged PRs (30d)
6

Description

**Describe the bug**
### Bamboo 7.0
In new version of Bamboo CI was changed bamboo_inject_prId -> bamboo_repository_pr_key
Check bamboo.repository.pr.key [here]((https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html))

### Bamboo CI repo naming
Also regex trigger only repos with underscores (ssh://git@bitbucket.mycompany.com:7999/my_project/my_repository.git)
If you have name style with dots (ssh://git@bitbucket.mycompany.com:7999/my_project/my.repository.git) it fails.

**To Reproduce**
Steps to reproduce the behavior:
1. Run danger in repo with doted name style (ssh://git@bitbucket.mycompany.com:7999/my_project/my.repository.git)
2. Get fail
3.
4.

**Expected behavior**
It should process repo with doted name

**Screenshots**
If applicable, add screenshots to help explain your problem.
CleanShot 2020-07-09 at 19 53 45@2x

** Your Environment**

| software | version
| ---------------- | -------
| danger.js | 10.2.1
| node | v14.5.0
| npm | 6.14.5
| Operating System | macOS Catalina 10.15.5 (19F101)

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by locating the Bamboo CI integration and the regular expression that parses repository names, then reproduce the two reported cases: Bamboo 7.0's pull-request variable and a repository name containing a dot. Done means both cases are processed successfully and are covered by relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
ci-cd, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.