danfickle / danfickle/openhtmltopdf

Display: table not working anymore after updating to v1.0.10 used in pseudo-element :after

Open
#844 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.2k
Forks
423
PR merge metrics
No merged PRs in 30d

Description

Hello,
I'm working on a project, where we use thymeleaf to design .html files. These are being transformed to pdf. In our case we used to "clean up" after specific elements, decorating them with

```
.icon-headline:after {
content: "";
display: table;
clear: both;
}
```
This was used to make sure, float: left and such were cleared. This, let me call it, "small hack" didn't work anymore after transitioning from v.1.0.8 to v1.0.10 and our tables, border headlines and such were left all messed up. I noticed in the patchnotes a line about

#711 (mixed) Better boxing for ::before and ::after content. Should now be able to define a border around pseudo content correctly.

Unfortunately this issue can't be found anymore so I decided to make one on my own in order to gain knowledge of what has happened.

I'm not sure what is meant with "better boxing" but I found out that when I use
```
.icon-headline:after {
content: "";
display: block;
clear: both;
}
```

swapping to block this mechanic still works. I'm curious what has changed or why I need to swap to block because I pretty much found this out by playing around a bit.

Thanks in advance for a bit of clarification :)
Phq

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.