danfickle / danfickle/openhtmltopdf

Wrong Position of Accents for Sequences of DIN 91379

Open
#777 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.2k
Forks
423
PR merge metrics
No merged PRs in 30d

Description

# Wrong position of accents for sequences defined in DIN 91379
## Describe the bug

The position of the accents is incorrect for most of the character sequences
defined in the following specification:

DIN SPEC 91379: Characters in Unicode for the electronic processing of names
and data exchange in Europe; with digital attachment
https://www.xoev.de/downloads-2316#StringLatin
https://www.din.de/de/wdc-beuth:din21:301228458

E.g. with 0041 030B LATIN CAPITAL LETTER A WITH COMBINING DOUBLE ACUTE ACCENT
the accent appears at the right hand side of the letter A, not above the
letter A.

## To Reproduce

Render Din91379-Letters.html and Din91379-List.html with OPEN HTML TO PDF.

## Expected behavior

The correct rendering should look like the output of HarfBuzz hb-view 2.9.1
for Din91379-Sequences.txt, see Din91379-Sequences.png.
HarfBuzz uses the info in the OpenType GPOS table for the positioning of
combining diacritical marks.

hb-view.exe -o Din91379-Sequences.png NotoSans-Regular.ttf < Din91379-Sequences.txt
See https://github.com/harfbuzz/harfbuzz.

## Screenshots
### Rendering with OPEN HTML TO PDF
![image](https://user-images.githubusercontent.com/39316085/136540467-f3a5bf50-0de4-4e4f-a9eb-b94d2ea004d5.png)

### Rendering with HarfBuzz
![Din91379-Sequences](https://user-images.githubusercontent.com/39316085/136536563-2a01c9e8-6ee9-45e3-bdd7-f5132384eed7.png)

## System (please complete the following information):

OS: Windows 10
Used Font: NotoSans, NotoSansMath,
see https://github.com/googlefonts/noto-fonts/tree/main/hinted/ttf/NotoSans,
https://github.com/googlefonts/noto-fonts/tree/main/hinted/ttf/NotoSansMath

## Additional context

See also
https://issues.apache.org/jira/browse/PDFBOX-4951
https://github.com/LibrePDF/OpenPDF/issues/442
https://issues.apache.org/jira/browse/FOP-2969
googlefonts/noto-fonts#1882

## Files
### Letters of DIN91379
[din91379_letters_all.txt](https://github.com/danfickle/openhtmltopdf/files/7310417/din91379_letters_all.txt)
[din91379_list_all.txt](https://github.com/danfickle/openhtmltopdf/files/7310418/din91379_list_all.txt)
[Din91379-Sequences.txt](https://github.com/danfickle/openhtmltopdf/files/7310343/Din91379-Sequences.txt)
### HTML-Files
[Din91379-Letters.html](https://github.com/danfickle/openhtmltopdf/files/7310369/Din91379-Letters.html.txt)
[Din91379-List.html](https://github.com/danfickle/openhtmltopdf/files/7310370/Din91379-List.html.txt)
### PDF-files rendered with OPEN HTML TO PDF
[Din91379-Letters.html.pdf](https://github.com/danfickle/openhtmltopdf/files/7310340/Din91379-Letters.html.pdf)
[Din91379-List.html.pdf](https://github.com/danfickle/openhtmltopdf/files/7310342/Din91379-List.html.pdf)
### Java program to reproduce the bug
[Test1.java](https://github.com/danfickle/openhtmltopdf/files/7310445/Test1.java.txt)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.