daneden / daneden/Toast

Overflow issue using full width

Open
#45 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
CSS
Stars
2k
Forks
253
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have discovered a little issue when I was trying to make a full width layout.

If you check my codepen --> http://codepen.io/andresgl/full/xZEyXR/ you can see a extra tittle right margin.

I have fixed it by myself changing the "margin-right" on .#{$toast-grid-column-namespace}

_(codepend SCSS line 187 and 188)_

`margin-right: -.3125em;`

instead of

`margin-right: -.25em;`

(5px) instead of (4px).
![toast grid - issue marging full-width](https://cloud.githubusercontent.com/assets/5893216/12008793/90ee3096-ac4e-11e5-832f-d85a9b823437.png)

Maybe you can solve it in another way.

Thank you!

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the full-width layout using the linked CodePen, then inspect the SCSS at lines 187-188 for .#{$toast-grid-column-namespace}. Done means removing the extra right margin while keeping the grid layout aligned at full width.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.