Revisit the #406 solution once #437 is merged
- Dominant language
- Python
- Stars
- 7
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Description
The solution adopted for #406 was written against the `wasGeneratedBy` annotations in `dandischema/models.py` that #437 revises. It should be revisited once #437 is merged.
The solution lives in two places on `linkml-conversion`:
- [`dandischema/models_merge.yaml`](https://github.com/dandi/dandi-schema/blob/bedd2975/dandischema/models_merge.yaml#L11-L18)
- [`tools/linkml_conversion_tools/remove_notes_by_pattern.py`](https://github.com/dandi/dandi-schema/blob/bedd2975/tools/linkml_conversion_tools/remove_notes_by_pattern.py#L42-L49)
What the adjustment should be depends on the form #437 takes when it is accepted, so nothing is proposed here yet.
- [ ] Revisit the #406 solution against the merged form of #437.
Follows #406, under #389.
Contributor guide
No contributing guide indexed for this repository
Research direction
Wait until #437 is merged, then compare its revised `wasGeneratedBy` annotations in `dandischema/models.py` with the existing solution. Review `dandischema/models_merge.yaml` and `tools/linkml_conversion_tools/remove_notes_by_pattern.py` at the referenced sections, and update both places so the #406 solution matches the merged form of #437.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100