dandi / dandi/dandi-cli

"straighten up" extract_session

Open
#698 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
28
Forks
37
Avg merge
1d 17h
Merged PRs (30d)
9

Description

Ran into while reviewing #669 and it is OOS for that PR so filing separately

We have
```
def extract_session(metadata: dict) -> list:
```
but that function
- can return `None`, so I guess it should become
```
def extract_session(metadata: dict) -> Optional[list]:
```
- we return a list but have `extract_session` not `sessions`. Should we return a singular `models.Session` and listify it outside may be so that name is more consistent with return value?

WDYT @satra @jwodder ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.