dandi / dandi/dandi-archive

Update zarr ingestion test to ensure unique faker pystr values

Open
#943 0 comments 0 reactions 0 assignees View on GitHub
DX enhancement tests
Dominant language
Python
Stars
26
Forks
21
Avg merge
4d 23h
Merged PRs (30d)
15

Description

I'm not sure of the randomness of `pystr`, but it's generally a good idea to include the iterated value in the generated path to prevent collisions (`path=f'foo/baz/{i}_{faker.pystr()}'`). Especially with 1005 entries, you're likely to hit one eventually.

_Originally posted by @dchiquito in https://github.com/dandi/dandi-archive/pull/914#discussion_r816910745_

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the zarr ingestion test that creates 1005 entries and inspect how it uses faker.pystr() to build generated paths. Run the test, then verify that the paths incorporate the iterated value and remain unique across all entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.