dandi / dandi/dandi-archive

Don't send emails in the request thread

Open
#597 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
26
Forks
21
Avg merge
4d 23h
Merged PRs (30d)
15

Description

As it currently stands, we generally send emails directly from view methods. If something were to go wrong with the email sending, the API request would fail, even though the operation completed successfully. We should either delegate the sending of the email to a task or wrap the sending of the email in a try/catch to ensure it never disrupts the request.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the view methods that send emails and trace how those sends affect the request response. Review the available task or error-handling patterns before choosing an approach; done means a failed email does not fail an otherwise completed API operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.