dandi / dandi/dandi-archive

Move ContactPerson extraction into `dandischema`

Open
#426 1 comment 0 reactions 0 assignees View on GitHub
DX enhancement good first issue refactor
Dominant language
Python
Stars
26
Forks
21
Avg merge
4d 23h
Merged PRs (30d)
15

Description

[The logic for extracting a dandiset's contact person from its version metadata](https://github.com/dandi/dandi-api/blob/master/dandiapi/api/views/serializers.py#L7-L17) should be moved to dandischema and exported as a function that dandi-api can use.

This will prevent the Contact Person display in the UI from breaking again in the event of a schema change.

Forgot to file this issue and was reminded when I saw https://github.com/dandi/dandi-api/issues/352.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the extraction logic in dandi-api/dandiapi/api/views/serializers.py lines 7-17 and review the related context in issue #352. Trace how dandischema is exported and consumed by dandi-api; done means the extraction is provided there as an exported function and the API uses it for the Contact Person display.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.