Don't consider existing tags when setting object tags
- Dominant language
- Python
- Stars
- 26
- Forks
- 21
- Avg merge
- 4d 23h
- Merged PRs (30d)
- 15
Description
We recently changed how to set object tags, to always consider what exists before blindly setting them.
https://github.com/dandi/dandi-archive/blob/f222f03af8ddc1e628fcb0422cabb69ea1c927c7/dandiapi/api/services/embargo/utils.py#L26-L29
However, since we know what the value of these tags will be from the database, we should authoritatively set them based on those database values. At the moment, the only tag we use is `embargoed`. However, in the future, that could change.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at dandiapi/api/services/embargo/utils.py, especially lines 26-29, and trace how the database supplies the current object tag values. Confirm that tag updates use those authoritative values rather than considering existing tags; the current behavior should remain correct for the embargoed tag and future database-backed tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100