dandavison / dandavison/delta

Fix clippy warnings

Open
#424 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
32.2k
Forks
572
Avg merge
11m
Merged PRs (30d)
1

Description

Right now some clippy warnings are allowed in the code. They look something like this:

https://github.com/dandavison/delta/blob/15d06cbf7584570ec3b5beaba99cb8898f9ec3dc/src/paint.rs#L243

So just search for the word "clippy" in the code and you will find them.
You should do the following:

1. run cargo clippy and check that there are no warnings
2. delete the allow line
3. run cargo clippy and check that you have a warning now
4. try to fix the warning

The only one you should not remove MAYBE it's `#[allow(clippy::tabs_in_doc_comments)]`. But I am not sure about this.

Contributor guide

Open the contributing guide

Research direction

Search the codebase for "clippy" and inspect the allow line linked in src/paint.rs. Run cargo clippy, remove each applicable allow, rerun it to confirm the warning, and fix the warning; verify cargo clippy finishes without warnings, while assessing whether tabs_in_doc_comments should remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.