dandavison / dandavison/delta

Default dark theme: contrast is too low for comment in addition line

Open
#294 7 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
32.2k
Forks
572
Avg merge
11m
Merged PRs (30d)
1

Description

Hi, thanks for sharing this amazing tool.

I noticed that when we have a comment that was added, the contrast of grey text on the green background is extremely low which makes it hard to read. Perhaps we could increase the brightness of the text, or increase the darkness of the green background?

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the default dark theme and the low-contrast comment in an addition line shown in the issue image. Locate the color-theme configuration or entry point responsible for that text and background, then verify that the revised colors make the comment readable without reducing the distinction for additions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
accessibility, cli, design
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.