dakrone / dakrone/clj-http

The :redirect-strategy doesn't seem to work for PUT and PATCH HTTP methods

Open
#641 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
1.8k
Forks
410
PR merge metrics
No merged PRs in 30d

Description

In my project, I use the Slash handler provided by Reitit library to remove the trailing / of any URL. This works with the help of HTTP 308 redirect. When trying to do the request using the PATCH HTTP method, I discovered that the :redirect-strategy setting is ignored. I receive the same request result with 308 status as if there was no redirect strategy set. The same happens for the PUT request. However, POST request to the very same address is handled correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the trailing-slash redirect through the Reitit Slash handler with PUT, PATCH, and POST requests, then trace clj-http's redirect handling around the :redirect-strategy setting. Done means PUT and PATCH follow the configured redirect strategy consistently with POST, with regression coverage for the affected methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.