Misnamed keyword on exception type?
Open
Nobody has claimed this yet.
4.x
- Dominant language
- Clojure
- Stars
- 1.8k
- Forks
- 410
- PR merge metrics
- No merged PRs in 30d
Description
Hey guys, I was looking through the code, and I noticed that here we're naming the keyword unexceptional-status - shouldn't it be namedexceptional-status since unexceptional-status-for-request? returned false ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/clj_http/client.clj around lines 236-240, starting with unexceptional-status-for-request? and the unexceptional-status keyword. Confirm whether the keyword name matches the predicate result, then check nearby references for consistent usage. Done means the naming is corrected if needed and the surrounding behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100