daisy / daisy/ace

landmark-no-duplicate-banner / landmark-unique flagged in some instances but not others

Open
#450 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
98
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Hello,

I have observed that the following errors get flagged when there is an `aside` with a `header` that is a child of a `section` that also has a `header`:

> landmark-no-duplicate-banner *Via: aXe*
>
> - Document has more than one banner landmark
> - Ensure the document has at most one banner landmark
> - Document should not have more than one banner landmark

> landmark-unique *Via: aXe*
> - The landmark must have a unique aria-label, aria-labelledby, or title to make landmarks distinguishable
> - Ensure landmarks are unique
> - Landmarks should have a unique role or role/label/title (i.e. accessible name) combination

[Learn about: ARIA](https://github.com/daisy/ace/issues/new#)

Document has more than one banner landmark
Ensure the document has at most one banner landmark
Document should not have more than one banner landmark

Here is the HTML for the document in question. The errors are flagged for the header of aside.

```html



Chapter 16 xxxxx





Chapter
16
xxxxx





xxxxx



xxxxxxxxxx


xxxxx xxxx xxxxx




xxxx




  • xxxxxx





```

Here is a file with `aside` with `header` child that does not trigger these errors:

```html



xxxxx




xxxxx



xxx x x x x x




x xx x x x



xxxxxxx




xxx


vvvv



xx x x






xxx


xxxxx



xxxxx


xxxxx






xxxx



xxxxx






xxxxX


xxxx



xxxxxx





xxxxx







xxxxx


xxxxx



xxxxx





>> xxxxx




  1. xxxxx




```

Trying to seek some understanding on this rule. I am aware that using hgroup would resolve this but I am not sure if this rule is not incorrect or not.

Thanks,
Franco

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.