daisy / daisy/ace

When Winston logger is fixed, remove hacky workaround that detects file stream flush / buffer write completion

Open
#272 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
98
Forks
29
PR merge metrics
No merged PRs in 30d

Description

`master` branch:

https://github.com/daisy/ace/blob/5d4cc866af8141180980522748c0aa82830afb7a/packages/ace-logger/src/index.js#L40-L72

Ace-GUI branch (updated Winston NPM dependency, still the same problem):

https://github.com/daisy/ace/blob/449df931cc75c1e5a50b0cfe2605563ade58ab2e/packages/ace-logger/src/index.js#L81-L96

https://github.com/daisy/ace/blob/449df931cc75c1e5a50b0cfe2605563ade58ab2e/packages/ace-logger/src/index.js#L11-L38

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.