daisy / daisy/ace

Localization: internal change - use the "meta" package to specify the list of supported languages for all 3 currently-localized packages

Open
#248 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
98
Forks
29
PR merge metrics
No merged PRs in 30d

Description

This proposed change would mean that future l10n contributions wouldn't have to modify the `packages/ace-XXX/src/l10n/localize.js` source code for each of the 3 currently-localised packages. For example, see this recent Pull Request:

https://github.com/daisy/ace/pull/246/files#diff-38adeefea9ae9024cab3ce220f321259

Caveat: conditional/dynamic `require()` calls (which would be needed in order to iterate the array of supported locales) may be problematic with some code bundlers, at build time.

To be investigated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.