daisy / daisy/MathCAT

Build a cache of files and dirs

Open
#402 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
114
Forks
85
Avg merge
1d 11h
Merged PRs (30d)
42

Description

Currently, if zip files are included, they get read and stored as a sort of fake file system.

For the non-zip version, it would be useful to do this so that we know what is inside the zipped up files without actually unzipping. This allows for discovery of regional variants. It probably would also speed MathCAT up since it wouldn't need to hit the file system much. I'm not sure about that though because of the cost of reading the zip files. The value of the `CheckRuleFiles` pref needs to be consulted for updating the cache.

Currently the code has a hack/special case for zh/tw. There is an en/gb regional variation, but because "en" gets unzipped for all versions, that case is discovered, but a es/mx variant wouldn't currently be discovered. Also, "zh" is identified as a language directory due to the regional subdir, but since it lacks any files, it shouldn't be. Again, this is only knowable by examining the zip files (currently that bug exists also for the `include-zip` case.

Probably a lot of code used by the `include-zip` case can be reused for building a cache.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.