daimajia / daimajia/AndroidSwipeLayout

getDragEdge() doesn't reflect StyledAttribute

Open
#144 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
12.3k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Bug Found When Testing:
https://github.com/jpshelley/AndroidSwipeLayout/blob/create_test_suite/library/src/test/java/com/daimajia/swipe/SwipeLayoutTest.java#L54

Should getDrageEdge() reflect the StyledAttribute if applied here:
https://github.com/jpshelley/AndroidSwipeLayout/blob/create_test_suite/library/src/main/java/com/daimajia/swipe/SwipeLayout.java#L88

expected: if dragEdgeChoices is DRAG_LEFT then getDragEdge() equals DRAG_LEFT
actual: if dragEdgeChoices is (DRAG_LEFT or DRAG_TOP or DRAG_BOTTOM) then getDragEdge() equals DRAG_RIGHT

if so I will update the variable in my testing branch.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.